Current time: 12-16-2017, 11:10 PM Hello There, Guest! (LoginRegister)

Post Reply 
 
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Start Render in HAR export
07-24-2012, 08:58 AM
Post: #1
Start Render in HAR export
Hello Smile First up, I know it's been said to death but thanks everyone (Pat especially) a bundle for the awesome site, advice, community, and tools.

I'm working on implementing a HAR file parser and thought it could be cool if the start render time was available in a WPT HAR export. I realise it's not part of the HAR 1.1/1.2 spec, so it would need to be optional (similar to the _pageSpeed score).

Instead of nagging I thought I'd have a crack at it, and it seems to work by modifying www/webpagetest/export.php, line 133 from:

Code:
$pd['pageTimings'] = array( 'onLoad' => $data['docTime'], 'onContentLoad' => -1 );

to

Code:
$pd['pageTimings'] = array( 'onLoad' => $data['docTime'], 'onContentLoad' => -1, '_startRender' => $data['render'] );

Does this seem like the correct approach and does it make sense to include it? If so I could check it in, but I think I have a read only copy of the source.. (I followed http://code.google.com/p/webpagetest/source/checkout - excuse my inexperience).

Thanks!
Pete
Find all posts by this user
Quote this message in a reply
07-25-2012, 01:07 AM
Post: #2
RE: Start Render in HAR export
Yep, that's pretty much exactly what you'd want to do. The code tree is locked and only allows checkins from approved committers. If you send me a patch (pmeenan@webpagetest.org) I can merge it in. I'm happy to accept enhancements and patches.

After several patches I'll usually approve you to become a committer.
Visit this user's website Find all posts by this user
Quote this message in a reply
07-25-2012, 03:27 AM
Post: #3
RE: Start Render in HAR export
Cool, thanks - patch sent.
Find all posts by this user
Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)