JS error in the filmstrip comparison
|
04-27-2013, 01:30 AM
Post: #1
|
|||
|
|||
JS error in the filmstrip comparison
I noticed a parse error in some filmstrip comparison :
http://www.webpagetest.org/video/compare...be8eb358d9 In this page, one of the test seems to have an empty value, so the JS generating the graphs is failing. Code: dataTimes.setValue(0, 0, 'Visually Complete'); Here is a simple fix, in video/compare.php : PHP Code: foreach($timeMetrics as $metric => $label) { A better fix would be to know why for some tests data is missing ![]() Jean-pierre VINCENT braincracking.org Fork of WPT monitor private instance : https://github.com/jpvincent/WPT-server |
|||
04-27-2013, 01:43 AM
Post: #2
|
|||
|
|||
RE: JS error in the filmstrip comparison
Excellent find, thank you. The sometimes-missing graphs has been on my list to look at for a while. Should be fixed now (well, patched - haven't looked into the root cause yet).
|
|||
« Next Oldest | Next Newest »
|
User(s) browsing this thread: 1 Guest(s)