![]() |
WebPageTest & PHP 5.4 - Printable Version +- WebPagetest Forums (https://www.webpagetest.org/forums) +-- Forum: WebPagetest (/forumdisplay.php?fid=7) +--- Forum: Bugs/Issues (/forumdisplay.php?fid=10) +--- Thread: WebPageTest & PHP 5.4 (/showthread.php?tid=11197) |
WebPageTest & PHP 5.4 - Aaron Kulick - 06-06-2012 02:59 AM Patrick, As of PHP version 5.4 the 'import_request_variables' function is deprecated (PHP Manual) You reference it in common.inc: Code: import_request_variables('PG', 'req_'); I encountered this issue on a new server I was setting up a new host. Of course, I was a bit slow to notice that common.inc had error_reporting(0) no matter how much error reporting I turned up in the php.ini nothing was showing up. This small change to common.inc resolves the issue: Code: extract($_REQUEST, EXTR_PREFIX_ALL|EXTR_REFS, 'req_'); Here is a small patch, however, it is untested on anything, but PHP 5.4: Code: --- /home/webperfdash/common.inc 2012-06-05 16:55:53.336551754 +0000 -Aaron RE: WebPageTest & PHP 5.4 - pmeenan - 06-07-2012 03:36 AM Thanks. I'm making a minor tweak but testing now and will commit shortly: Code: extract($_POST, EXTR_SKIP|EXTR_PREFIX_ALL|EXTR_REFS, 'req'); The main thing I was trying to accomplish was that $_REQUEST depends on the configuration of request_order in php.ini and I had a case where a cookie value collided with a post parameter and it led to really "interesting" behavior. Also, watch out for the underscore after req, php adds it automatically with extract() |